[FFmpeg-devel] [PATCH v2 1/3] avutil/hwcontext: add a function to get the AVHWDeviceType

Anton Khirnov anton at khirnov.net
Sat Jul 2 11:50:38 EEST 2022


Quoting Wu, Tong1 (2022-07-01 08:51:28)
> Plus, do you think adding a AV_PIX_FMT_FLAG_HWACCEL check for the
> input pixel format and change the function name to
> av_hwdevice_get_type_by_hwaccel_pix_fmt will help?

I'd prefer not to, that name is way too long

> Let users know only hardware pixel formats are acceptable for this
> function and like I said at this moment not any hardware format is
> supported by more than one hardware devices.

Maybe just document in the doxy that it will return the preferred device
type for a pixel format.

Overall I don't insist on any changes here, mainly wondering if anyone
can think of a potential future case where we'd want a single pixel
format supported by multiple devices

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list