[FFmpeg-devel] [PATCH v2] libavutil/tests/md5: Avoid warnings

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of James Almer
> Sent: Friday, January 21, 2022 2:45 AM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v2] libavutil/tests/md5: Avoid warnings
> 
> 
> 
> On 1/20/2022 10:41 PM, softworkz wrote:
> > From: softworkz <softworkz at hotmail.com>
> >
> > Those are always showing up on Patchwork
> > when FATE tests are failing, covering
> > some possibly more useful information.
> >
> > Signed-off-by: softworkz <softworkz at hotmail.com>
> > ---
> >      libavutil/tests/md5: Avoid warnings
> >
> >      Those are always showing up on Patchwork when FATE tests are failing,
> >      covering some possibly more useful information.
> >
> > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-
> ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v2
> > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-
> 20/softworkz/submit_md5-v2
> > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20
> >
> > Range-diff vs v1:
> >
> >   1:  3910d81fa1 ! 1:  4723054463 libavutil/tests/md5: Avoid warnings
> >       @@ libavutil/tests/md5.c: int main(void)
> >         {
> >             uint8_t md5val[16];
> >             int i;
> >       -+
> >       -+#if defined(__clang__) && defined(__clang_major__) &&
> __clang_major__ < 4
> >       -     volatile uint8_t in[1000]; // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> >       +-    volatile uint8_t in[1000]; // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> >        -    // FIXME remove volatile once it has been fixed and all fate
> clients are updated
> >       -+#else
> >       -+    uint8_t in[1000];
> >       ++
> >       ++#if 1 || defined(__clang__) && defined(__clang_major__) &&
> __clang_major__ < 4
> >       ++    volatile // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> >        +#endif
> >       ++    uint8_t in[1000];
> >
> >             for (i = 0; i < 1000; i++)
> >                 in[i] = i * i;
> >
> >
> >   libavutil/tests/md5.c | 7 +++++--
> >   1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c
> > index 42e4538e0a..cca63d6507 100644
> > --- a/libavutil/tests/md5.c
> > +++ b/libavutil/tests/md5.c
> > @@ -33,8 +33,11 @@ int main(void)
> >   {
> >       uint8_t md5val[16];
> >       int i;
> > -    volatile uint8_t in[1000]; // volatile to workaround
> http://llvm.org/bugs/show_bug.cgi?id=20849
> > -    // FIXME remove volatile once it has been fixed and all fate clients
> are updated
> > +
> > +#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__
> < 4
> 
> 1?

I'm an idiot...

Thanks