[FFmpeg-devel] [PATCH] avformat/img2dec: fix logic error in GEM Raster file probe

Peter Ross pross at xvid.org
Fri Jan 21 00:14:05 EET 2022


Use correct logic to express limits of the planes and pattern_size fields.

Fix ticket# 9605

Signed-off-by: Peter Ross <pross at xvid.org>
---
 libavformat/img2dec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c
index 4d5ac51b53..2583ca2465 100644
--- a/libavformat/img2dec.c
+++ b/libavformat/img2dec.c
@@ -1115,8 +1115,8 @@ static int gem_probe(const AVProbeData *p)
     int ret = 0;
     if ( AV_RB16(b     ) >= 1 && AV_RB16(b    ) <= 3  &&
          AV_RB16(b +  2) >= 8 && AV_RB16(b + 2) <= 779 &&
-        (AV_RB16(b +  4) > 0  || AV_RB16(b + 4) <= 8) &&
-        (AV_RB16(b +  6) > 0  || AV_RB16(b + 6) <= 8) &&
+        (AV_RB16(b +  4) > 0  && AV_RB16(b + 4) <= 32) && /* planes */
+        (AV_RB16(b +  6) > 0  && AV_RB16(b + 6) <= 8) && /* pattern_size */
          AV_RB16(b +  8) &&
          AV_RB16(b + 10) &&
          AV_RB16(b + 12) &&
-- 
2.34.1

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220121/d773b81e/attachment.sig>


More information about the ffmpeg-devel mailing list