[FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

[Kyle Swanson]

Hi,

On Thu, Jan 13, 2022 at 6:38 PM Kyle Swanson <k at ylo.ph> wrote:
>
> Hi,
>
> On Mon, Jan 10, 2022 at 10:22 AM Andreas Rheinhardt
> <andreas.rheinhardt at outlook.com> wrote:
> > 1. FFmpeg uses the ancient C90 rule that only allows variable
> > declarations at the beginning of a block (before all statements). You
> > should actually have received a compiler warning because of the above
> > code (unless you use Clang, which claims to support this type of
> > warning, yet doesn't).
> > 2. You jump over the initializion of str_copy if the dict allocation
> > fails and consequently you free an uninitialized string.
>
> New patch attached. Fixes all of the GCC -Wdeclaration-after-statement
> warnings. You're right, I didn't notice because I was building with
> Clang. Andreas, I will just wait for your LGTM before merging.
>
> Thanks,
> Kyle

Updated patch attached. Thank you to mkver for the mini review on IRC.
The `delimited_dict_parse` multi-delimiter corner case should be
sorted now.

Thanks,
Kyle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avfilter-vf_libvmaf-update-filter-for-libvmaf-v2.0.0.patch
Type: application/octet-stream
Size: 35777 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220119/70fd3e3e/attachment.obj>