[FFmpeg-devel] [PATCH 24/28] ffmpeg_mux: drop a useless check and reduce indentation

Anton Khirnov anton at khirnov.net
Tue Jan 18 12:52:07 EET 2022


Quoting Andreas Rheinhardt (2022-01-18 11:35:13)
> And if you swapped the patches it would be only two lines for an
> ordinary git show; not because of git show functionality, but because
> the patch only touches two lines.

And I would have to spend extra time dealing with rebase conflicts. Not
wasting people's time should be a factor in reviews.

I wouldn't mind if there was a point to it, but optimizing diff size
doesn't seem particularly meaningful to me. Especially since that code
would get touched anyway, so it's not making things easier for git blame
either.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list