[FFmpeg-devel] [PATCH 06/24] avcodec/subtitles: Migrate subtitle encoders to frame-based API

[Michael Niedermayer]

On Fri, Jan 14, 2022 at 01:13:15AM +0000, ffmpegagent wrote:
> From: softworkz <softworkz at hotmail.com>
> 
> and provide a compatibility shim for the legacy api
> 
> Signed-off-by: softworkz <softworkz at hotmail.com>
> ---
>  libavcodec/assenc.c        | 189 ++++++++++++++++++++++++++++++-------
>  libavcodec/avcodec.h       |   5 +-
>  libavcodec/dvbsubenc.c     |  96 ++++++++++---------
>  libavcodec/dvdsubenc.c     | 102 ++++++++++++--------
>  libavcodec/encode.c        |  57 ++++++++++-
>  libavcodec/movtextenc.c    | 114 ++++++++++++++++------
>  libavcodec/srtenc.c        | 108 ++++++++++++++-------
>  libavcodec/tests/avcodec.c |   2 -
>  libavcodec/ttmlenc.c       | 101 +++++++++++++++-----
>  libavcodec/webvttenc.c     |  86 ++++++++++++-----
>  libavcodec/xsubenc.c       |  88 ++++++++++-------
>  11 files changed, 685 insertions(+), 263 deletions(-)

is this supposed to pass make fate without the later patches ?

it seems not here:

--- ./tests/ref/fate/sub-webvtt2	2022-01-13 23:24:22.195685643 +0100
+++ tests/data/fate/sub-webvtt2	2022-01-14 18:04:09.528302263 +0100
@@ -11,15 +11,3 @@
 
 [Events]
 Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text
-Dialogue: 0,0:00:00.00,0:00:20.00,Default,,0,0,0,,Hi, my name is Fred
-Dialogue: 0,0:00:02.50,0:00:22.50,Default,,0,0,0,,Hi, I’m Bill
-Dialogue: 0,0:00:05.00,0:00:25.00,Default,,0,0,0,,Would you like to get a coffee?
-Dialogue: 0,0:00:07.50,0:00:27.50,Default,,0,0,0,,Sure! I’ve only had one today.
-Dialogue: 0,0:00:10.00,0:00:30.00,Default,,0,0,0,,This is my fourth!
-Dialogue: 0,0:00:12.50,0:00:32.50,Default,,0,0,0,,OK, let’s go.
-Dialogue: 0,0:00:38.00,0:00:43.00,Default,,0,0,0,,I want to 愛あい love you\NThat's not proper English!
-Dialogue: 0,0:00:43.00,0:00:46.00,Default,,0,0,0,,{\i1}キツネ{\i0}じゃない　キツネじゃない\N乙女おとめは
-Dialogue: 0,0:00:50.00,0:00:55.00,Default,,0,0,0,,Some time ago in a rather distant place....
-Dialogue: 0,0:00:55.00,0:01:00.00,Default,,0,0,0,,Descending: 123456\NAscending: 123456
-Dialogue: 0,0:01:00.00,0:01:05.00,Default,,0,0,0,,>> Never gonna give you up Never gonna let you down\NNever\hgonna\hrun\haround & desert\hyou
-Dialogue: 0,0:55:00.00,1:00:00.00,Default,,0,0,0,,Transcrit par Célestes™
Test sub-webvtt2 failed. Look at tests/data/fate/sub-webvtt2.err for details.
tests/Makefile:256: recipe for target 'fate-sub-webvtt2' failed
make: *** [fate-sub-webvtt2] Error 139

if you cannot reproduce then say so and ill get e better backtrace

Program received signal SIGSEGV, Segmentation fault.
0x0000000000000000 in ?? ()
(gdb) bt
#0  0x0000000000000000 in  ()
#1  0x0000555555c7d2cf in avcodec_encode_subtitle ()
#2  0x0000555555744daa in transcode_subtitles ()
#3  0x000055555574b9eb in process_input_packet ()
#4  0x000055555574d64d in transcode ()
#5  0x0000555555725ebc in main ()



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Take away the freedom of one citizen and you will be jailed, take away
the freedom of all citizens and you will be congratulated by your peers
in Parliament.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220114/458bbc41/attachment.sig>