[FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define

[Marton Balint]

On Fri, 7 Jan 2022, Soft Works wrote:

>
>
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Marton
>> Balint
>> Sent: Friday, January 7, 2022 8:57 PM
>> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
>> Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't
>> dump images to disk based on DEBUG define
>>
>>
>>
>> On Fri, 7 Jan 2022, ffmpegagent wrote:
>>
>>> It's annoying and unexpected, but still useful at times (as I've realized
>>> just recently).
>>>
>>> This is a follow-up to the earlier submission here:
>>> https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg128080.html
>>>
>>> There has been a comment from Anton, questioning whether the dump-feature
>> is
>>> useful. Meanwhile I came to the conclusion that it can be useful in-fact.
>> It
>>> just shouldn't happen automatically when DEBUG is defined. That's what
>> these
>>> patches do.
>>
>> Well, I kind of agree with Anton, this a debug feature and it should not
>> be added as an option, but simply should be removed from the codebase.
>
> It's not added as a regular option. It's an option that is only available
> when you compile with DEBUG defined.

Ah, OK.

>
> Isn't this an acceptable compromise?

Well, I am not a fan of leaving DEBUG chunks in the codebase to be 
honest. But if somebody applies it, then fine with me.

Thanks,
Marton