[FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define

Hendrik Leppkes h.leppkes at gmail.com
Fri Jan 7 12:20:22 EET 2022


On Fri, Jan 7, 2022 at 5:50 AM ffmpegagent <ffmpegagent at gmail.com> wrote:
>
> It's annoying and unexpected, but still useful at times (as I've realized
> just recently).
>
> This is a follow-up to the earlier submission here:
> https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg128080.html
>
> There has been a comment from Anton, questioning whether the dump-feature is
> useful. Meanwhile I came to the conclusion that it can be useful in-fact. It
> just shouldn't happen automatically when DEBUG is defined. That's what these
> patches do.
>
> I also added fixes for the fopen() call.
>
> softworkz (4):
>   avcodec/dvbsubdec: don't dump images to disk based on DEBUG define
>   avcodec/dvbsubdec: fix writing ppm
>   avcodec/dvdsubdec: don't dump images to disk based on DEBUG define
>   avcodec/dvdsubdec: fix writing ppm
>
>  libavcodec/dvbsubdec.c | 20 +++++++++++++-------
>  libavcodec/dvdsubdec.c | 11 ++++++++---
>  2 files changed, 21 insertions(+), 10 deletions(-)
>
>

These patches need some squasing. It should've been obvious from them
being duplicated.

- Hendrik


More information about the ffmpeg-devel mailing list