[FFmpeg-devel] [PATCH v11 5/5] fate/matroska: Add tests for reading/writing BlockAdditionMapping elements

[Andreas Rheinhardt]

quietvoid:
> Tests the parsing and writing of AVDOVIDecoderConfigurationRecord,
> when it is present as a Dolby Vision configuration block addition mapping.
> 
> Signed-off-by: quietvoid <tcChlisop0 at gmail.com>
> ---
> The required regression test file is available here: https://0x0.st/-hWK.mkv
> Should be moved to fate-suite/mkv/dovi-p5.mkv
> 
> It is a blank frame encoded with x265.
> ---
>  tests/fate/matroska.mak                      |   9 +
>  tests/ref/fate/matroska-dovi-config-profile5 |  13 ++
>  tests/ref/fate/matroska-dovi-write-config    | 223 +++++++++++++++++++
>  3 files changed, 245 insertions(+)
>  create mode 100644 tests/ref/fate/matroska-dovi-config-profile5
>  create mode 100644 tests/ref/fate/matroska-dovi-write-config
> 
> diff --git a/tests/fate/matroska.mak b/tests/fate/matroska.mak
> index e117a0f6a6..ec2a0607b2 100644
> --- a/tests/fate/matroska.mak
> +++ b/tests/fate/matroska.mak
> @@ -138,6 +138,15 @@ FATE_MATROSKA_FFMPEG_FFPROBE-$(call ALLYES, FILE_PROTOCOL WEBVTT_DEMUXER  \
>                                 += fate-webm-webvtt-remux
>  fate-webm-webvtt-remux: CMD = transcode webvtt $(TARGET_SAMPLES)/sub/WebVTT_capability_tester.vtt webm "-map 0 -map 0 -map 0 -map 0 -c:s copy -disposition:0 original+descriptions+hearing_impaired -disposition:1 lyrics+default+metadata -disposition:2 comment+forced -disposition:3 karaoke+captions+dub" "-map 0:0 -map 0:1 -c copy" "" "-show_entries stream_disposition:stream=index,codec_name:packet=stream_index,pts:packet_side_data_list -show_data_hash CRC32"
>  
> +FATE_MATROSKA_FFMPEG_FFPROBE-$(call ALLYES, MATROSKA_DEMUXER) += fate-matroska-dovi-config-profile5

This should be FATE_MATROSKA_FFPROBE, not FATE_MATROSKA_FFMPEG_FFPROBE.
And actually, you need the file protocol; if you don't check for it,
you can just use FATE_MATROSKA_FFPROBE-$(CONFIG_MATROSKA_DEMUXER).

> +fate-matroska-dovi-config-profile5: CMD = run ffprobe$(PROGSSUF)$(EXESUF) -show_entries stream_side_data_list -select_streams v -v 0 $(TARGET_SAMPLES)/mkv/dovi-p5.mkv
> +
> +FATE_MATROSKA_FFMPEG_FFPROBE-$(call ALLYES, FILE_PROTOCOL PIPE_PROTOCOL \
> +                                            MOV_DEMUXER MATROSKA_MUXER \
> +                                            FRAMECRC_MUXER) \

You will need the MATROSKA_DEMUXER, too; after all, the created file is
read and demuxed.

> +                               += fate-matroska-dovi-write-config
> +fate-matroska-dovi-write-config: CMD = transcode mov $(TARGET_SAMPLES)/hevc/dv84.mov matroska "-c:v copy" "-map 0 -c copy" "" "-show_entries stream_side_data_list -select_streams v -v 0"
> +
>  FATE_SAMPLES_AVCONV += $(FATE_MATROSKA-yes)
>  FATE_SAMPLES_FFPROBE += $(FATE_MATROSKA_FFPROBE-yes)
>  FATE_SAMPLES_FFMPEG_FFPROBE += $(FATE_MATROSKA_FFMPEG_FFPROBE-yes)