[FFmpeg-devel] [PATCH v2 1/2] tools: add general_assembly.pl

Nicolas George george at nsup.org
Thu Feb 24 15:46:40 EET 2022


Thilo Borgman (12022-02-24):
> Both LGTM.

Does it?

The way I remember it, this condition was for the initial assembly, as a
temporary measure. I might have missed some steps, but I do not remember
we adopted this as a constant rule.

I see several flaws with it:

- Documentation patches were not counted, now they are.

- Cosmetic patches are counted.

- It does not take the size of the changes.

Using an imperfect solution for bootstrap is one thing, using it
permanently is another.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220224/959aee1e/attachment.sig>


More information about the ffmpeg-devel mailing list