[FFmpeg-devel] [PATCH] libavfilter: zscale performance optimization >4x

Anton Khirnov anton at khirnov.net
Mon Feb 21 13:22:16 EET 2022


> libavfilter: zscale performance optimization >4x

This reads like an advertisement rather than a useful description. It
should say what the patch does, performance improvement numbers should
be mentioned in the commit message body.

Quoting Victoria Zhislina (2022-02-21 09:20:55)
> By ffmpeg threading support implementation via frame slicing and doing
> zimg_filter_graph_build that used to take 30-60% of each frame processig
> only if necessary (some parameters changed)
> the performance increase vs original version
> in video downscale and color conversion  >4x is seen
> on 64 cores Intel Xeon, 3x on i7-6700K (4 cores with HT)

This implies the patch does multiple unrelated things. Then it should be
split in multiple patches, unless some important factor prevents that
(then that factor should be described in the commit message).

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list