[FFmpeg-devel] [RFC][PATCH 1/4] avutil/frame: add an internal field to store the size of AVFrame

James Almer jamrial at gmail.com
Sat Feb 12 14:16:36 EET 2022


On 2/12/2022 9:08 AM, Michael Niedermayer wrote:
> On Fri, Feb 11, 2022 at 09:12:58PM -0300, James Almer wrote:
>> This is unfortunately needed to remove (or reduce the awfulness) of certain
>> modules violating the AVFrame API and using sizeof(AVFrame).
>> With this, the sizeof(AVFrame) value of the libavutil loaded at runtime can be
>> used instead of the compile time value of whatever library included frame.h
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> This is sucks, but at least less so than the current situation.
>>
>> I don't see wrapped_avframe going away anytime soon, so something must be done,
>> and last time i tried to change how the packets are generated my approach was
>> shut down, so here's another attempt.
> 
> iam probably missing something but if the goal is to wrap AVFrame in some
> other structure as a array or buffer
> without the sizeof(AVFrame) cant the wraping/unwraping code be put in
> libavutil ?

How would that fix the situation of setting AVPacket.size to 
sizeof(AVFrame) and AVPacket.data to an structure that big + padding 
bytes in packets returned to the caller?

> 
> thx
> 
> [...]
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".



More information about the ffmpeg-devel mailing list