[FFmpeg-devel] [PATCH 2/2] libavformat/mov: fix udta reading in trak box

[Jan Ekström]

On Tue, Feb 8, 2022 at 9:48 AM Wang Chuan <ouchuanm at outlook.com> wrote:
>
> Any news？
>

Sorry, was not able to get to this according to the time line I
expected. Will see if I can find some time for this soon.

The attempt I had done in October was quite similar now that I look at
it again (https://github.com/jeeb/ffmpeg/commits/enable_writing_udta_metadata_for_tracks),
although it seems like I missed c->trak_index , will have to check it
:)

Additionally, when I did the changes a lot of tests had to be updated
as the test would expect the metadata in the main context, as
previously the metadata only got applied globally. The changes in my
commit aren't what's needed as I just committed the changes in test
results to remind myself which tests would require additional changes
or at least review.

Looking at the patchwork side for this patch set, it seems like it
wasn't able to run the tests for you, so you probably did not get any
messages about failing tests?
https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=5839

For running tests locally, what I usually do is:

1. configure and build normally
2. `make fate-rsync SAMPLES=../../path/to/fate-suite`
3. `make fate SAMPLES=../../path/to/fate-suite`

this is also documented at https://www.ffmpeg.org/fate.html .

For the movenc patch, I think there was this weird thing where in QTFF
there were two different "name" metadata entries (as well as the
international one you've pointed out). I don't think I mentioned it on
https://github.com/mpv-player/mpv/issues/8488#issuecomment-884381794
as it contains only my initial findings, but I'll have to grep my IRC
logs :D .

Thank you for your contribution and patience,

Jan