[FFmpeg-devel] [PATCH v2 07/13] avpriv_find_start_code(): constify pointer parameters

Scott Theisen scott.the.elm at gmail.com
Sat Feb 5 08:08:15 EET 2022


On 2/5/22 00:49, Andreas Rheinhardt wrote:
>> - * @param[in,out] start_code A reference to a mutable @c uint32_t.<br>
>> + * @param[in,out] start_code A constant pointer (reference) to a mutable @c uint32_t.<br>
> There are no references in C.

A pointer is a type of reference.  However, I agree "A pointer to a 
mutable @c uint32_t.<br>" would be clearer.

> Documenting restrictions on the callee that are irrelevant to the caller
> in a public header seems weird.

Fair enough, the added consts shall be limited to libavcodec/utils.c.

-Scott


More information about the ffmpeg-devel mailing list