[FFmpeg-devel] [PATCH v2 11/13] cbs_mpeg2.c: improve readability of start code search (part 1)
Scott Theisen
scott.the.elm at gmail.com
Sat Feb 5 05:53:18 EET 2022
On 2/4/22 21:16, Andreas Rheinhardt wrote:
> Using a pre-increment is unnatural (i is supposed to be the number of
> units of the fragment and so it should naturally be incremented after a
> unit has been successfully added to the fragment) and impairs clarity.
>
It *is* incremented after a unit has been successfully added, on the
*next* iteration.
> redundant comment
>
Debatable, the variable is already a uint8_t*, albeit const qualified.
The purpose of comments is to explain.
More information about the ffmpeg-devel
mailing list