[FFmpeg-devel] [PATCH v2 67/69] avcodec/mpegvideo_dec: Remove commented-out cruft

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Tue Feb 1 15:07:04 EET 2022


This piece of code has been added in an already commented-out state
in commit 158c7f059c3906b0116ae73a7669a3bb7bc570bb. It certainly
doesn't make sense now (if ever) because new_picture_ptr it used
has been removed in 6571e41dcdee4655237bca0a3277df8976167aee
(and new_picture is only used for encoding).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
 libavcodec/mpegvideo_dec.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libavcodec/mpegvideo_dec.c b/libavcodec/mpegvideo_dec.c
index 48371aa886..8927a0a21b 100644
--- a/libavcodec/mpegvideo_dec.c
+++ b/libavcodec/mpegvideo_dec.c
@@ -358,8 +358,6 @@ int ff_mpv_frame_start(MPVMainDecContext *m, AVCodecContext *avctx)
     s->current_picture_ptr->field_picture      =  s->picture_structure != PICT_FRAME;
 
     s->current_picture_ptr->f->pict_type = s->pict_type;
-    // if (s->avctx->flags && AV_CODEC_FLAG_QSCALE)
-    //     s->current_picture_ptr->quality = s->new_picture_ptr->quality;
     s->current_picture_ptr->f->key_frame = s->pict_type == AV_PICTURE_TYPE_I;
 
     if ((ret = ff_mpeg_ref_picture(s->avctx, &s->current_picture,
-- 
2.32.0



More information about the ffmpeg-devel mailing list