[FFmpeg-devel] [PATCH 05/18] lavc/dv: remove ff_dvvideo_init()

Anton Khirnov anton at khirnov.net
Thu Aug 25 12:55:43 EEST 2022


Quoting Anton Khirnov (2022-08-25 11:48:27)
> Quoting Andreas Rheinhardt (2022-08-24 14:27:43)
> > There is actually another issue here: Encoders are not supposed to set
> > chroma_sample_location at all according to the documentation. I sent a
> > patch to implement this
> > (https://ffmpeg.org/pipermail/ffmpeg-devel/2022-July/298518.html -- it
> > also inlines and removes ff_dvvideo_init()), but I am unsure whether it
> > is not the documentation that needs to be updated.
> 
> I would say update the documentation. It does make sense for encoders to
> set this field.

Or on second thought, maybe no. Apparently no other encoders set it.
Though we might want to check whether the value matches and warn/error
out otherwise.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list