[FFmpeg-devel] [PATCH v3] mov: Compare frag times in correct time base when seeking a stream without a corresponding sidx

[Derek Buitenhuis]

On 8/17/2022 11:29 AM, Zhao Zhili wrote:
>> This seems like it should be in a separate patch, though - it is
>> changing a different
>> behavior than what this patch does.
> 
> OK.

Will send a 2nd patch with this in the next few days.


>> I did look at that, but I do not think it can be.
>>
>> get_stream_info_time is not equivalent to what is here.
>> get_stream_info_time will
>> eventually fall back to frag_stream_info->tfdt_dts, where as this
>> code falls back
>> to frag_stream_info->sidx_pts even if it is AV_NOPTS_VALUE. It would
>> be a behavior
>> change do use get_stream_info_time here.
> 
> OK, it make sense together with `if (sc->has_sidx)`.
> 
> No more comments from me.

Applied. Thank you for your reviews :).

- Derek