[FFmpeg-devel] [PATCH v3 0/3] checkasm: updated tests for sw_scale

Swinney, Jonathan jswinney at amazon.com
Sat Aug 13 23:55:48 EEST 2022


> We don't generally use stdbool in ffmpeg, even if it's C99 - just use a 
> plain int and 0/1.
Updated this.

> Other than that, the checkasm changes look fine (I coauthored part of 
> them - and your cleanup of my WIP patch looks good!).
Yes, thank you for the help on that!

> Hmm, can you elaborate on this bit? With only the first patch applied, the 
> checkasm test still succeeds.
That was leftover from when my test was broken. Is that that with the fixed
test, it works fine.

> Could we split this improvement for the existing codepath into a separate 
> preceding patch, to keep things a bit clearer?
I split it out. Let me know if I didn't split like you intended.

Thanks again for your review!

Jonathan Swinney



More information about the ffmpeg-devel mailing list