[FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec

[Dawid Kozinski/Robot SDK (PLT) /SRPOL/Staff Engineer/삼성전자]

Hi Michael, 

After I'd applied my patches onto master ffmpeg branch then I ran ffmpeg FATE but FATE didn't report any issues.

I followed the steps described on https://ffmpeg.org/fate.html
make fate-rsync SAMPLES=fate-suite/
make fate       SAMPLES=fate-suite/

Then I checked tests/ref/fate/source file but it didn't contain any reports about issues inside.
It looks like follows:

Files without standard license headers:
libavcodec/file_open.c
libavcodec/ilbcdata.h
libavcodec/ilbcdec.c
libavcodec/interplayacm.c
libavcodec/log2_tab.c
libavcodec/reverse.c
libavdevice/file_open.c
libavdevice/reverse.c
libavfilter/af_arnndn.c
libavfilter/file_open.c
libavfilter/log2_tab.c
libavformat/file_open.c
libavformat/golomb_tab.c
libavformat/log2_tab.c
libswresample/log2_tab.c
libswscale/log2_tab.c
tools/uncoded_frame.c
tools/yuvcmp.c
Headers without standard inclusion guards:
compat/djgpp/math.h
compat/float/float.h
compat/float/limits.h
tools/decode_simple.h
Use of av_clip() where av_clip_uintp2() could be used:
Use of av_clip() where av_clip_intp2() could be used:

I'm not able to reproduce the issue pointed out by you.
Tell me please if I do something the wrong way.

Any hints will be appreciated.

-----Original Message-----
From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Michael Niedermayer
Sent: Thursday, August 11, 2022 11:06 PM
To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec

On Thu, Aug 11, 2022 at 02:36:47PM +0200, Dawid Kozinski wrote:
> - Added muxer for EVC format (MP4, raw)
> - Added demuxer for EVC format (MP4)
> - Added evc extension to the list of extensions for ff_mov_demuxer
> - Added information to moov atom
[...]
> diff --git a/libavformat/evc.h b/libavformat/evc.h
> new file mode 100644
> index 0000000000..d7b93d521d
> --- /dev/null
> +++ b/libavformat/evc.h
> @@ -0,0 +1,147 @@
> +/*
> + * EVC helper functions for muxers
> + * Copyright (c) 2022 Dawid Kozinski <d.kozinski at samsung.com>
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */
> +
> +#ifndef AVFORMAT_EVC_H
> +#define AVFORMAT_EVC_H
[...]
> +#endif // AVFORMAT_EVC_H

> \ No newline at end of file

fate-source  is not happy about this:

--- ./tests/ref/fate/source	2022-07-29 22:42:50.354493777 +0200
+++ tests/data/fate/source	2022-08-11 22:54:59.715488573 +0200
@@ -21,6 +21,7 @@
 compat/djgpp/math.h
 compat/float/float.h
 compat/float/limits.h
+libavformat/evc.h
 tools/decode_simple.h
 Use of av_clip() where av_clip_uintp2() could be used:
 Use of av_clip() where av_clip_intp2() could be used:
Test source failed. Look at tests/data/fate/source.err for details.
tests/Makefile:304: recipe for target 'fate-source' failed
make: *** [fate-source] Error 1



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope