[FFmpeg-devel] [PATCH v12 13/13] configure: add --enable-libvpl option

[Xiang, Haihao]

On Mon, 2022-08-01 at 15:27 +0200, Anton Khirnov wrote:
> Quoting Xiang, Haihao (2022-07-25 06:11:51)
> > +elif enabled libvpl; then
> > +# Consider pkg-config only. The name of libmfx is still passed to
> > check_pkg_config function for --enable-libvpl option
> > +# because QSV has dependency on libmfx, we can use the same dependency if
> > using libmfx in this check. The package name
> > +# is extracted from "vpl >= 2.6"
> > +    check_pkg_config libmfx "vpl >= 2.6" "mfxvideo.h mfxdispatcher.h"
> > MFXLoad && \
> > +        warn "build FFmpeg against oneVPL 2.6+, OPAQUE memory, multi-frame
> > encode, user plugins\n"\
> > +             "and LA_EXT rate control mode in FFmpeg QSV won't be
> > supported." ||
> 
> I don't think printing warnings in the default path is a good idea.
> Warnings should only be printed in nonstandard situations, otherwise
> users just learn to ignore them.

I'm sorry I missed your comment here. I'll delete this warning and won't send a
new version if no other comments.

Thanks
Haihao