[FFmpeg-devel] [PATCH] avcodec/aacdec: print a log message when treating mono HE-AAC as stereo

Anton Khirnov anton at khirnov.net
Tue Aug 2 14:13:18 EEST 2022


Quoting James Almer (2022-07-28 19:22:47)
> Since this behavior is intentional, use the VERBOSE level instead of WARNING as
> it's nothing the user should worry about.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavcodec/aac.h             | 1 +
>  libavcodec/aacdec_template.c | 4 ++++
>  libavcodec/aacsbr_template.c | 2 ++
>  3 files changed, 7 insertions(+)
> 
> diff --git a/libavcodec/aac.h b/libavcodec/aac.h
> index 53be546857..c8d6b17710 100644
> --- a/libavcodec/aac.h
> +++ b/libavcodec/aac.h
> @@ -366,6 +366,7 @@ struct AACContext {
>      int warned_960_sbr;
>      unsigned warned_71_wide;
>      int warned_gain_control;
> +    int warned_he_aac_mono;

I now count 6 warned_foo vars in the context, which is quite wasteful.
We might want to change those into flags.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list