[FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Xiang, Haihao
> Sent: Wednesday, April 6, 2022 5:38 AM
> To: anton at khirnov.net; ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related
> code when MFX_VERSION < 2.0
> 
> On Tue, 2022-04-05 at 13:50 +0200, Anton Khirnov wrote:
> > Quoting Xiang, Haihao (2022-03-11 09:16:25)
> > > From: Haihao Xiang <haihao.xiang at intel.com>
> > >
> > > Audio isn't supported for MFX_VERSION >= 2.0[1][2]. This is in
> > > preparation for oneVPL support
> > >
> > > [1]:
> > >
> https://spec.oneapi.io/versions/latest/elements/oneVPL/source/VPL_inte
> l_media_sdk.html#msdk-full-name-feature-removals
> > > [2]: https://github.com/oneapi-src/oneVPL
> > > ---
> > >  libavcodec/qsv.c     | 5 +++++
> > >  libavfilter/qsvvpp.c | 6 ++++++
> > >  libavfilter/qsvvpp.h | 2 ++
> > >  3 files changed, 13 insertions(+)
> >
> > Why not just remove this completely?
> > None of our QSV code  does anything with audio.
> 
> It was removed in an older version, however someone objected the
> removal of
> this.  See
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200819061023.44330
> 4-2-haihao.xiang at intel.com/

I think this was a misunderstanding. I see not objection. One was 
just asking "why" and the other one had missed the point that audio
has never been functional.

I agree with Anton that the audio stuff should be removed 
completely - ideally even beforehand in a separate patch.

softworkz