[FFmpeg-devel] [PATCH v9 6/6] fftools: Use UTF-8 on Windows

[nil-admirari at mailo.com]

> This needs a similar commit message as what I suggested for the previous 
> commit, explaining what it does, when, why, and clarifying that this is a 
> noop for older versions.

Done: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295572.html.

> In particular, it'd be interesting to know why we actually need this; we 
> normally should be doing all the conversions between wchar_t and utf8 
> everywhere anyway, so the exact codepage used shouldn't really matter 
> much? I presume the main noticable benefit is that it improves the path 
> name compatibility with avisynth which is stuck on using CP_ACP pathnames?

Yes, it is primarily due to AviSynth. From https://github.com/staxrip/staxrip/wiki/AviSynth-Unicode-support-on-Windows-10-1903:

> All AviSynth apps used by StaxRip have a UTF-8 manifest to enable full Unicode support for AviSynth on Windows 10 1903 or higher:
> ...
> ffmpeg.exe (Patman Mod)
> ...
> On Windows 10 1903 or higher all these apps expect AviSynth scripts to be UTF-8 encoded, ANSI encoded scripts don't work.