[FFmpeg-devel] [PATCH] avfilter/elbg: Extend filter to include alpha values in the quantization procedure

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Paul B Mahol
> Sent: Tuesday, 28 September 2021 18:05
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] avfilter/elbg: Extend filter to
> include alpha values in the quantization procedure
> 
> On Tue, Sep 28, 2021 at 5:43 PM Soft Works <softworkz at hotmail.com>
> wrote:
> 
> >
> >
> > > -----Original Message-----
> > > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> > > Paul B Mahol
> > > Sent: Monday, 27 September 2021 18:37
> > > To: FFmpeg development discussions and patches <ffmpeg-
> > > devel at ffmpeg.org>
> > > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/elbg: Extend filter
> to
> > > include alpha values in the quantization procedure
> > >
> > > On Mon, Sep 27, 2021 at 5:30 PM Michael Niedermayer
> > > <michael at niedermayer.cc>
> > > wrote:
> > >
> > > > On Sun, Sep 26, 2021 at 05:56:36PM +0000, Soft Works wrote:
> > > > >
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On
> Behalf
> > > Of
> > > > > > Michael Niedermayer
> > > > > > Sent: Sunday, 26 September 2021 18:52
> > > > > > To: FFmpeg development discussions and patches <ffmpeg-
> > > > > > devel at ffmpeg.org>
> > > > > > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/elbg: Extend
> > > filter to
> > > > > > include alpha values in the quantization procedure
> > > > > >
> > > > > > On Sun, Sep 26, 2021 at 04:57:25AM +0000, Soft Works wrote:
> > > > > > > Usage example:
> > > > > > >
> > > > > > > ffmpeg -y -loglevel verbose -i "..\fate-
> > > suite\apng\o_sample.png" -
> > > > > > filter_complex "elbg=pal8=1:use_alpha=1" -frames:v 1
> out.png
> > > > > > >
> > > > > > > Signed-off-by: softworkz <softworkz at hotmail.com>
> > > > > > > ---
> > > > > > >  doc/filters.texi      |  4 ++++
> > > > > > >  libavfilter/vf_elbg.c | 25 ++++++++++++++++---------
> > > > > > >  2 files changed, 20 insertions(+), 9 deletions(-)
> > > > > >
> > > > > > will apply
> > > > >
> > > > > Thank you.
> > > > >
> > > > > Please allow me another note: I think the naming of this
> filter
> > > > > is terrible. I've gone through the list of all ffmpeg filters
> > > > > many more times than the typical user, but without the
> specific
> > > > > pointers I had gotten from you and a few other devs, I would
> > > > > have never identified the "elbg" filter as something that
> > > > > would do what I'm looking for.
> > > >
> > > > i would tend to agree, yes, in fact i think
> > > > finding filters based on what they do is hard
> > > > and iam not sure their names alone should be how they need to
> be
> > > found
> > > >
> >
> > The names can't be it alone, but good naming would be a helpful
> > element.
> >
> >
> > > Every filter have short description. So next time use grep or
> search
> > > feature.
> >
> > You have added a large range of audio filters and I'm sure many of
> > them are very useful, but I'm afraid that often I do not have the
> > slightest clue about what they are doing, not even when reading the
> > description text ;-)
> >
> 
> Are you audio engineer? Follow documentation.

Accidentally, I'm quite familiar with audio production and studio 
technology, that's why I'm sure that even for audio engineers it's 
not always clear what the filters are doing. The documentation is 
often too minimal and it would be nice when it would include 
example use cases and example command lines.
Same as for the elbg filter, I don't mean it in a negative way.
What I mean is that it's somewhat unfortunate to put so much effort
in developing those filters, when their benefits remain to be invisible
for the majority of users.

softworkz