[FFmpeg-devel] [PATCH] avfilter/frames: Ensure frames are writable when processing in-place

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Soft Works
> Sent: Monday, 27 September 2021 14:12
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] avfilter/frames: Ensure frames
> are writable when processing in-place
> 
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> > Nicolas George
> > Sent: Monday, 27 September 2021 14:10
> > To: FFmpeg development discussions and patches <ffmpeg-
> > devel at ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/frames: Ensure frames
> > are writable when processing in-place
> >
> > Soft Works (12021-09-27):
> > > With the introduction of subtitle filtering, subsequent video
> > frames
> > > which are sharing the same data won't be as rare as this happened
> > > to occur yet.
> > > Ensuring per-frame uniqueness when data is modified is not only
> > important
> > > to avoid issues in the future, but a common API requirement
> anyway.
> > >
> > > Signed-off-by: softworkz <softworkz at hotmail.com>
> > > ---
> >
> > NAK, redundant.
> 
> Why?

You mean because of AVFILTERPAD_FLAG_NEEDS_WRITABLE?

It should be deprecated IMO, it's not a good API design.

softworkz