[FFmpeg-devel] [PATCH 2/2] avcodec/mmaldec: fix deprecation warning

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Thu Sep 23 19:52:29 EEST 2021


Ho Ming Shun:
> Signed-off-by: Ho Ming Shun <cyph1984 at gmail.com>
> ---
>  libavcodec/mmaldec.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c
> index 5b75a1e74d..96140bf53d 100644
> --- a/libavcodec/mmaldec.c
> +++ b/libavcodec/mmaldec.c
> @@ -772,7 +772,9 @@ static int ffmmal_decode(AVCodecContext *avctx, void *data, int *got_frame,
>  
>      if (avctx->extradata_size && !ctx->extradata_sent) {
>          AVPacket pkt = {0};
> +FF_DISABLE_DEPRECATION_WARNINGS
>          av_init_packet(&pkt);
> +FF_ENABLE_DEPRECATION_WARNINGS
>          pkt.data = avctx->extradata;
>          pkt.size = avctx->extradata_size;
>          ctx->extradata_sent = 1;
> 

You did not fix the underlying issue (av_init_packet() is deprecated and
its use should therefore be discontinued), but just hid the warning.
This patch here:
https://ffmpeg.org/pipermail/ffmpeg-devel/2021-March/277278.html intends
to fix the underlying issue (and also the warning). I have just not
found anyone to actually test whether it works. I presume you could do
it. Would you be so kind and do it?

- Andreas

PS: There is also a second patch of this patchset:
https://ffmpeg.org/pipermail/ffmpeg-devel/2021-March/277279.html
You can get the patches from patchwork here if that is easier for you:
https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=3470
Or use this command line to apply the patches directly:
curl https://patchwork.ffmpeg.org/series/3470/mbox/ | git am -3


More information about the ffmpeg-devel mailing list