[FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

[lance.lmwang at gmail.com]

On Thu, Sep 23, 2021 at 05:11:49PM +0300, Jan Ekström wrote:
> On Thu, Sep 23, 2021 at 4:46 PM Christopher Degawa <ccom at randomderp.com> wrote:
> >
> > On Sun, Sep 19, 2021 at 2:02 PM Christopher Degawa <ccom at randomderp.com>
> > wrote:
> >
> > >
> > >
> > > On Fri, Sep 17, 2021 at 9:28 PM <lance.lmwang at gmail.com> wrote:
> > >
> > >> From: Limin Wang <lance.lmwang at gmail.com>
> > >>
> > >> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> > >>
> > > As a note, I personally favor this patch over mine since I don't think
> > > `enable_tpl_la` is worth exposing to the user if its main role is to switch
> > > between crf and cqp
> > >
> >
> > Ping on this patch, this has been requested on SVT-AV1's side as well
> 
> I think my further comments on the previous version were mostly to
> move off from the rc option for rate control, which has become more
> and more seemingly unnecessary (and different from most other encoders
> for no obvious reason).
> 
> The only option that with a quick look doesn't match just setting
> quantizer|bit rate|CRF is "cvbr", but it doesn't seem to be impossible
> to either rework "rc" for it, or to utilize a separate option for it.

Do you think it's OK to remove the rc option? to match other encoders, 
We can choose the rate control by the related parameters like:

if (crf >= 0)
    choose crf rate control;
else if (bitrate > 0)
    choose cvbr rate control;
else if (cqp >=0 )
    choose cqp rate control;

> 
> Basically the idea is to get it more or less to match other encoders,
> so that the wrapper doesn't feel completely alien to the rest of
> things.
> 
> Jan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

-- 
Thanks,
Limin Wang