[FFmpeg-devel] [PATCH 3/5] avformat/matroskaenc: Write dvcC/dvvC block additional mapping

[Andreas Rheinhardt]

quietvoid:
> 
> On 22/09/2021 22.03, Andreas Rheinhardt wrote:
>> quietvoid:
>>> +        put_ebml_string(pb, MATROSKA_ID_BLKADDIDNAME, "Dolby Vision
>>> configuration");
>>> +        put_ebml_uint(pb, MATROSKA_ID_BLKADDIDTYPE, type);
>>> +        put_ebml_binary(pb, MATROSKA_ID_BLKADDIDEXTRADATA, buf, size);
>>> +        end_ebml_master(pb, mapping);
>>> +    }
>>> +
>>> +    return 0;
>>> +}
>>> +
>>>   static int mkv_write_track(AVFormatContext *s, MatroskaMuxContext
>>> *mkv,
>>>                              AVStream *st, mkv_track *track,
>>> AVIOContext *pb,
>>>                              int is_default)
>>> @@ -1380,6 +1407,12 @@ static int mkv_write_track(AVFormatContext *s,
>>> MatroskaMuxContext *mkv,
>>>           return AVERROR(EINVAL);
>>>       }
>>>   +    // After video track, before private data
>> Is this required?
> 
> No, if DOVI side data can be assumed to always be along a video track.
> Which is the case, I think.
> 
> The order is not necessary but this is the same behaviour as other
> Matroska muxers.
> I've simply validated the elements with mkvinfo.
> 

Then please remove the comment. It suggests that this order is required
when it is not.

- Andreas