[FFmpeg-devel] [PATCH 4/4] avcodec/targa: Do not return images when there is no image in the tga

[Michael Niedermayer]

On Fri, Sep 17, 2021 at 08:06:48PM +0200, Paul B Mahol wrote:
> On Fri, Sep 17, 2021 at 8:00 PM Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > On Fri, Sep 17, 2021 at 07:35:32PM +0200, Paul B Mahol wrote:
> > > Please do not apply, This actually changes output to nothing.
> >
> > Do you have such a TGA file without an image in it?
> >
> > Why would that be relevant, comply with TGA specifications please.
> 
> thx

It is relevant as it would allow to check how such a file is handled
by various implementations
The specification does not specify that. It just says 
"No image Data included"
and our decoder returns a black image, the specification doesnt say that
means "black image" or i missed it when reading 
after the patch the decoder returns nothing instead of a black image
The other type this might reach is type 8, the specification i have doesnt
say anything about type 8 except that its reserved

    Truevision TGAa
FILE FORMAT SPECIFICATION
Version 2.0
...
Image Type - Field 3 (1 byte):
The TGA File Format can be used to store Pseudo-Color, True-Color and Direct-Color images of various
pixel depths. Truevision has currently defined seven image types:
image       Description
Type    0   No image Data included




[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210918/92d11d0a/attachment.sig>