[FFmpeg-devel] [PATCH] avdevice/avfoundation: continue to try get packet if not in observed_quit mode

Thilo Borgmann thilo.borgmann at mail.de
Fri Sep 17 19:12:38 EEST 2021


Hi,

On 19 Jul 2021, at 9:15, Steven Liu wrote:

> move unlock_frames before return in observed_quit mode.
> before patch:
> ./ffmpeg -f avfoundation -i ":0" -y out.wav
> say something to microphone
> ffplay out.wav will hear some noise, because not get enough samples 
> from
> devices
>
> after patch:
> ./ffmpeg -f avfoundation -i ":0" -y out.wav
> say something to microphone
> ffplay out.wav will ok.
>
> Signed-off-by: Steven Liu <liuqi05 at kuaishou.com>
> ---
>  libavdevice/avfoundation.m | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

I just applied some fixes related to the locking. Can you retest this, 
as it appears not really related to the locking but to behavior of 
EAGAIN if this changes things for you?

Thanks,
Thilo



More information about the ffmpeg-devel mailing list