[FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

[Sun Zhenliang]

在 2021年9月8日 +0800 21:48，Sun Zhenliang <hisunzhenliang at outlook.com>，写道：
> 在 2021年9月8日 +0800 17:55，Hendrik Leppkes <h.leppkes at gmail.com>，写道：
> > On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang <hisunzhenliang at outlook.com> wrote:
> > >
> > > Thanks for reviewing.
> > >
> > > Probing is expecting to find “correct” frames, which includes those kinds of comfort noise and NO_DATA frames mentioned in 3GPP Specifications.
> > >
> > > Besides, those frames are considered as normal frames while reading packets. It seems better to take the same standard of frames in both reading and probing.
> > >
> >
> > Can you answer the second question? Does this actually fix any files?
> > If so, can you provide one?
> >
> > As mentioned above, correct or not, this patch makes the probing
> > accept very loose bit patterns and is likely rather prone to
> > misdetections, so no matter if its more "correct", there are other
> > considerations here. So instead, lets start with seeing what it
> > actually fixes.
>
> Ok, there is the file that this patch fixed. It’s made by some kind of phone with header.
> I removed it’s header to test the probing at raw amr files.
> https://github.com/HiSunzhenliang/patch/blob/main/ffmpeg/silence-head.amrnb
> And this is ffmpeg log.
> https://github.com/HiSunzhenliang/patch/blob/main/ffmpeg/ffmpeg_i.log
> >
Ping
> > - Hendrik
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".