[FFmpeg-devel] [PATCH 2/2] avformat/mxf: support MCA audio information

Tomas Härdin tjoppen at acc.umu.se
Sun Sep 12 16:02:06 EEST 2021


@@ -2681,6 +2845,88 @@ static int
mxf_parse_structural_metadata(MXFContext *mxf)
                 st->internal->need_parsing = AVSTREAM_PARSE_FULL;
             }
             st->codecpar->bits_per_coded_sample =
av_get_bits_per_sample(st->codecpar->codec_id);
+
+            current_channel = 0;
+
+
+
+            for (j = 0; j < FFMIN(descriptor->channels,
FF_SANE_NB_CHANNELS); ++j) {

I feel like we should error out with an appropriate message rather than
silently ignoring any extra channels. Otherwise this looks pretty good

/Tomas



More information about the ffmpeg-devel mailing list