[FFmpeg-devel] [PATCH 27/38] avfilter/vf_vif: Remove empty options and AVClass

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Sun Sep 12 13:53:25 EEST 2021


This filter only had an AVClass and empty options because up until
recently, avfilter_init_str() errored out when options were provided
for a filter without an AVClass. But setting (generic) options is
necessary to take advantage of timeline support. So with
avfilter_init_str() fixed, the AVClass and the options can be removed.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
 libavfilter/vf_vif.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/libavfilter/vf_vif.c b/libavfilter/vf_vif.c
index da3069c1f6..13714d8673 100644
--- a/libavfilter/vf_vif.c
+++ b/libavfilter/vf_vif.c
@@ -28,7 +28,6 @@
 #include <float.h>
 
 #include "libavutil/avstring.h"
-#include "libavutil/opt.h"
 #include "libavutil/pixdesc.h"
 #include "avfilter.h"
 #include "framesync.h"
@@ -40,7 +39,6 @@
 #define NUM_DATA_BUFS 13
 
 typedef struct VIFContext {
-    const AVClass *class;
     FFFrameSync fs;
     const AVPixFmtDescriptor *desc;
     int width;
@@ -57,14 +55,6 @@ typedef struct VIFContext {
     uint64_t nb_frames;
 } VIFContext;
 
-#define OFFSET(x) offsetof(VIFContext, x)
-
-static const AVOption vif_options[] = {
-    { NULL }
-};
-
-AVFILTER_DEFINE_CLASS(vif);
-
 static const uint8_t vif_filter1d_width1[4] = { 17, 9, 5, 3 };
 
 static const float vif_filter1d_table[4][17] =
@@ -643,7 +633,6 @@ const AVFilter ff_vf_vif = {
     .uninit        = uninit,
     .query_formats = query_formats,
     .priv_size     = sizeof(VIFContext),
-    .priv_class    = &vif_class,
     .activate      = activate,
     FILTER_INPUTS(vif_inputs),
     FILTER_OUTPUTS(vif_outputs),
-- 
2.30.2



More information about the ffmpeg-devel mailing list