[FFmpeg-devel] [PATCH 31/34] avformat/tee: Fix leak of FIFO-options dictionary

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Mon Sep 6 05:27:59 EEST 2021


Happened for all slaves which didn't use the FIFO.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
 libavformat/tee.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/tee.c b/libavformat/tee.c
index 03356da6c0..4129954172 100644
--- a/libavformat/tee.c
+++ b/libavformat/tee.c
@@ -125,6 +125,7 @@ static int close_slave(TeeSlave *tee_slave)
     unsigned i;
     int ret = 0;
 
+    av_dict_free(&tee_slave->fifo_options);
     avf = tee_slave->avf;
     if (!avf)
         return 0;
@@ -230,6 +231,7 @@ static int open_slave(AVFormatContext *avf, char *slave, TeeSlave *tee_slave)
 
         av_dict_free(&options);
         options = tee_slave->fifo_options;
+        tee_slave->fifo_options = NULL;
     }
     ret = avformat_alloc_output_context2(&avf2, NULL,
                                          tee_slave->use_fifo ? "fifo" :format, filename);
-- 
2.30.2



More information about the ffmpeg-devel mailing list