[FFmpeg-devel] [PATCH 2/6] lavf/concat: add file_packet_meta directive

Nicolas George george at nsup.org
Thu Sep 2 18:19:45 EEST 2021


Andreas Rheinhardt (12021-08-31):
> realloc is not supposed to transfer ownership, av_dict_set() with these
> flags is. For me its behaviour makes sense (and avoids lots of av_free()
> on failure paths).

This is C, not Rust: ownership rules are in the eye of the beholder.

The objective thing to say is: av_dict_set() with DONT_STRDUP destroys
its argument in case of failure, realloc() does not.

Anyway, the problem is fixed, let us not split hairs furthers on this,
and thank you for spotting it.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210902/cd18ad4f/attachment.sig>


More information about the ffmpeg-devel mailing list