[FFmpeg-devel] [PATCH 10/10] lavfi/vf_scale: pass the thread count to the scaler

[Anton Khirnov]

Quoting Michael Niedermayer (2021-08-30 14:34:30)
> On Mon, Aug 30, 2021 at 11:38:53AM +0200, Michael Niedermayer wrote:
> > > I am not familiar with the generic scaler code, but it seems independent
> > > of this partitioning, otherwise the threaded scaling tests would fail.
> > 
> > the generic scaler simply stores the data originating from the previous slice
> > (generally after the horizontal scaler)
> > 
> > the 410->420 one probably should 
> > * store the one chroma line too somewhere
> > * initialize it to the first image line
> > * simplify all the 410->420 code so it always uses a pointer to the previous
> >   line either from the buffer or if available straight from the input image
> > 
> > It seems not worth for just 410->420, and i agree but the same could
> > be used for 420->444 and others which would have the same problem if one
> > wanted to do higher quality chroma interpolation in the unscaled special
> > converters
> 
> Just to clarify, this is meant as a path forward for the bug with chroma
> interpolation in the special converters which do or might want to use
> chroma interpolation. 
> Its not a review comment to the patchset(s)

Right, that's how I understood this.

Are you still looking at the patchset or shall I go ahead with pushing
it to master?

-- 
Anton Khirnov