[FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

[James Almer]

On 10/31/2021 3:34 PM, Pierre-Anthony Lemieux wrote:
>>> The functions are not static and are defined in imf_internal.h. They
>>> are used in both libavformat/imfdec.c and the tests at
>>> libavformat/tests/imf.c. Ok?
>>
>> If they are used in libavformat only it should be static.
> AFAIK static functions are only available in the compilation unit
> where they are defined, so if a static function (e.g.
> `parse_imf_asset_map_from_xml_dom()`) is defined in
> libavformat/imf_dec.c, it will not be available in
> libavformat/tests/imf.c.
> 
> Functions that can be used by other FFMPEG modules are declared in
> "imf.h", whereas functions that are intended to be used only by the
> IMF demuxer are declared in "imf_internal.h".
> 
> For example, both "libavformat/tests/imf.c" and "libavformat/imfdec.c"
> include "libavformat/imf_internal.h" so they can access
> `parse_imf_asset_map_from_xml_dom()`.
> 
> Does that work? Any alternative?

Tests in the library's test folder can and usually include the actual .c 
file from the module they are testing, so making it static will work fine.