[FFmpeg-devel] [PATCH] fftools/ffplay: don't disable x11 compositing

[Marton Balint]

On Fri, 29 Oct 2021, Marton Balint wrote:

>
>
> On Wed, 27 Oct 2021, Zane van Iperen wrote:
>
>>  Prevents desktop stutters caused by the change (specifically on KDE).
>>  We're not a game, we don't actually need it disabled.
>>
>>  Signed-off-by: Zane van Iperen <zane at zanevaniperen.com>
>>  ---
>>  fftools/ffplay.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>>  diff --git a/fftools/ffplay.c b/fftools/ffplay.c
>>  index ccea0e4578..4b2e69e613 100644
>>  --- a/fftools/ffplay.c
>>  +++ b/fftools/ffplay.c
>>  @@ -3746,6 +3746,10 @@ int main(int argc, char **argv)
>>              flags |= SDL_WINDOW_BORDERLESS;
>>          else
>>              flags |= SDL_WINDOW_RESIZABLE;
>>  +
>>  +#ifdef SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR
>>  +        SDL_SetHint(SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR, "0");
>>  +#endif
>
> Shouldn't this be SDL_SetHintWithPriority so the user may override it from an 
> environment variable?

Ah, never mind, SDL_SetHint can also be overidden. LGTM then, thanks.

Although this whole compositing mess is ugly and ideally we should not 
need something like this...

Regards,
Marton