[FFmpeg-devel] [PATCH 1/2 v2] avformat/mov: Use av_rescale when calculating bit rate

Michael Niedermayer michael at niedermayer.cc
Thu Oct 21 15:15:02 EEST 2021


On Wed, Oct 20, 2021 at 07:43:30PM +0100, Derek Buitenhuis wrote:
> It is less susceptible to overflows.
> 
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
> ---
>  libavformat/mov.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)

LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20211021/d79493fd/attachment.sig>


More information about the ffmpeg-devel mailing list