[FFmpeg-devel] [PATCH 4/4] lavc/aarch64: clean-up sao band 8x8 function formatting

[Martin Storsjö]

On Thu, 7 Oct 2021, J. Dekker wrote:

> Signed-off-by: J. Dekker <jdek at itanimul.li>
> ---
> libavcodec/aarch64/hevcdsp_sao_neon.S | 103 +++++++++++---------------
> 1 file changed, 44 insertions(+), 59 deletions(-)
>
> diff --git a/libavcodec/aarch64/hevcdsp_sao_neon.S b/libavcodec/aarch64/hevcdsp_sao_neon.S
> index 263747149f..c2519da7f5 100644
> --- a/libavcodec/aarch64/hevcdsp_sao_neon.S
> +++ b/libavcodec/aarch64/hevcdsp_sao_neon.S
> @@ -3,7 +3,7 @@
>  *
>  * AArch64 NEON optimised SAO functions for HEVC decoding
>  *
> - * Copyright (c) 2020 Josh Dekker <josh at itanimul.li>
> + * Copyright (c) 2020-2021  J. Dekker <jdek at itanimul.li>
>  *
>  * This file is part of FFmpeg.
>  *
> @@ -29,64 +29,49 @@
> //                      int16_t *sao_offset_val, int sao_left_class,
> //                      int width, int height)
> function ff_hevc_sao_band_filter_8x8_8_neon, export=1
> -        sub             sp,  sp, #64
> -        stp            xzr, xzr, [sp]

This one had the right indentation to start with, don't reindent it 
according to the new incorrectly indented code you're adding.

Also if you're going to reformat this, could you align the left edge of 
the operand columns instead of aligning the commas, i.e. making it match 
the rest of the asm we have? I.e. like this:

     sp,  sp,  #64
     xzr, xzr, [sp]


// Martin