[FFmpeg-devel] [PATCH v3 1/2] avcodec/codec_par: Add codec properties field to AVCodecParameters

[Hendrik Leppkes]

On Wed, Oct 6, 2021 at 8:45 AM Soft Works <softworkz at hotmail.com> wrote:
> diff --git a/libavcodec/codec_par.h b/libavcodec/codec_par.h
> index 10cf79dff1..42ed8deb13 100644
> --- a/libavcodec/codec_par.h
> +++ b/libavcodec/codec_par.h
> @@ -198,6 +198,10 @@ typedef struct AVCodecParameters {
>       * Audio only. Number of samples to skip after a discontinuity.
>       */
>      int seek_preroll;
> +    /**
> +     * Codec properties of the stream that gets decoded
> +     */
> +    unsigned properties;
>  } AVCodecParameters;
>

This field is severly underspecified/underdocumented. I realize you
just copied it, but if I'm looking at this without pre-existing
knowledge, then I have absolutely no idea what it might be for, or
what kind of values go in there. The old field had the defines of the
possible bits right there for context - this doesn't have this, so it
would definitely benefit from added documentation.

- Hendrik