[FFmpeg-devel] [PATCH] avformat/avio{, buf}: introduce public AVIOContext::bytes_read

Michael Niedermayer michael at niedermayer.cc
Sat Oct 2 13:32:32 EEST 2021


On Sun, Sep 26, 2021 at 06:48:18PM +0300, Jan Ekström wrote:
> Such a field can be seen as generally useful in cases where the
> API user is not implementing custom AVIO callbacks, but still would
> like to know if data is being read even if AVPackets are not being
> returned.
> ---
> Originally I thought about making an accessor for the private field, to
> not grow the public struct's size (and have a duplicate field, as well
> as making sure the value was read-only). But an objection was raised
> that such accessors should be refrained from as they unnecessarily
> filled the function symbol space or so. Together with the objection, a
> proposal of making it a field on the public struct that was only written
> to was proposed.
> 
> This patch follows that proposal. 
> 
>  doc/APIchanges        | 3 +++
>  libavformat/avio.h    | 5 +++++
>  libavformat/aviobuf.c | 2 ++
>  libavformat/version.h | 2 +-
>  4 files changed, 11 insertions(+), 1 deletion(-)

There are 3 statistics, read, write and seek
shouldnt all 3 be provided to the user?

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20211002/8363df29/attachment.sig>


More information about the ffmpeg-devel mailing list