[FFmpeg-devel] [PATCH 10/20] avformat/sccdec: Avoid zero-terminating unnecessarily

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Sat Oct 2 00:08:27 EEST 2021


ff_subtitles_queue_insert() does not require its events to be
zero-terminated as it has a parameter for the length.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
 libavformat/sccdec.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/libavformat/sccdec.c b/libavformat/sccdec.c
index ea9f014cf2..6935ea4c3e 100644
--- a/libavformat/sccdec.c
+++ b/libavformat/sccdec.c
@@ -117,8 +117,6 @@ static int scc_read_header(AVFormatContext *s)
             if (i > 12 && o1 == 0x94 && o2 == 0x20 && saveptr &&
                 (av_strncasecmp(saveptr, "942f", 4) && !av_strncasecmp(saveptr, "942c", 4))) {
 
-                out[i] = 0;
-
                 sub = ff_subtitles_queue_insert(&scc->q, out, i, 0);
                 if (!sub)
                     return AVERROR(ENOMEM);
@@ -136,8 +134,6 @@ static int scc_read_header(AVFormatContext *s)
             out[i+2] = o2;
         }
 
-        out[i] = 0;
-
         sub = ff_subtitles_queue_insert(&scc->q, out, i, 0);
         if (!sub)
             return AVERROR(ENOMEM);
-- 
2.30.2



More information about the ffmpeg-devel mailing list