[FFmpeg-devel] [PATCH 2/5] avformat/aviobuf: return stored AVIO context error on avio_close

Marton Balint cus at passwd.hu
Tue Nov 30 02:49:47 EET 2021


Otherwise IO errors at avio_flush() before closing may be lost.

Signed-off-by: Marton Balint <cus at passwd.hu>
---
 libavformat/aviobuf.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c
index 5da4dea7b6..d65c7b535d 100644
--- a/libavformat/aviobuf.c
+++ b/libavformat/aviobuf.c
@@ -1231,6 +1231,7 @@ int avio_close(AVIOContext *s)
 {
     FFIOContext *const ctx = ffiocontext(s);
     URLContext *h;
+    int ret, error;
 
     if (!s)
         return 0;
@@ -1249,9 +1250,14 @@ int avio_close(AVIOContext *s)
                ctx->bytes_read, ctx->seek_count);
     av_opt_free(s);
 
+    error = s->error;
     avio_context_free(&s);
 
-    return ffurl_close(h);
+    ret = ffurl_close(h);
+    if (ret < 0)
+        return ret;
+
+    return error;
 }
 
 int avio_closep(AVIOContext **s)
-- 
2.31.1



More information about the ffmpeg-devel mailing list