[FFmpeg-devel] [PATCH v17 14/19] avfilter/overlaytextsubs: Add overlaytextsubs and textsubs2video filters

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Michael
> Niedermayer
> Sent: Sunday, November 28, 2021 9:31 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v17 14/19] avfilter/overlaytextsubs: Add
> overlaytextsubs and textsubs2video filters
> 
> On Sat, Nov 27, 2021 at 07:38:07PM +0000, Soft Works wrote:
> > - overlaytextsubs {VS -> V)
> >   Overlay text subtitles onto a video stream.
> >
> > - textsubs2video {S -> V)
> >   Converts text subtitles to video frames
> >
> > Signed-off-by: softworkz <softworkz at hotmail.com>
> > ---
> >  configure                        |   2 +
> >  doc/filters.texi                 | 113 ++++++
> >  libavfilter/Makefile             |   2 +
> >  libavfilter/allfilters.c         |   4 +-
> >  libavfilter/vf_overlaytextsubs.c | 633 +++++++++++++++++++++++++++++++
> >  5 files changed, 753 insertions(+), 1 deletion(-)
> >  create mode 100644 libavfilter/vf_overlaytextsubs.c
> 
> (tested this as it was the last applying automatically)
> 
> this or a previous patch breaks:
> 
> ./ffmpeg -i ~/tickets/1332/Starship_Troopers.vob -scodec xsub -qscale 2 -an
> file1332.avi
> 
>   Stream #0:0: Video: mpeg4 (FMP4 / 0x34504D46), yuv420p(tv, top coded first
> (swapped)), 720x480 [SAR 32:27 DAR 16:9], q=2-31, 200 kb/s, 29.97 fps, 29.97
> tbn
>     Metadata:
>       encoder         : Lavc mpeg4
>     Side data:
>       cpb: bitrate max/min/avg: 0/0/200000 buffer size: 0 vbv_delay: N/A
>   Stream #0:1: Subtitle: xsub (DXSB / 0x42535844)
>     Metadata:
>       encoder         : Lavc xsub
> [mpeg @ 0x564897855840] New subtitle stream 0:7 at pos:8497166 and
> DTS:1999.51ss speed=14.6x
> Subtitle encoding failed - Error code: -1397118274
> Conversion failed!

Found and fixed for the next revision.

Thanks a lot for trying my patchset!

softworkz