[FFmpeg-devel] [PATCH] avformat: do not use AVIO_FLAG_* with avio_alloc_context
Anton Khirnov
anton at khirnov.net
Mon Nov 29 11:21:59 EET 2021
Quoting Marvin Scholz (2021-11-22 00:25:16)
> The documentation states that here 0 should be used for read-only and
> 1 for a writable buffer. AVIO_FLAG_WRITE however is 2, while it works
> due to the way the flag is handled internally, it is still wrong
> according to the documentation.
>
> Additionally it makes it seem as if the AVIO_FLAG_* values could be used
> here, which is actually not true, as when AVIO_FLAG_READ would be used
> here it would create a writable buffer as AVIO_FLAG_READ is defined as 1.
> ---
> libavformat/hdsenc.c | 2 +-
> libavformat/segment.c | 2 +-
> libavformat/smoothstreamingenc.c | 2 +-
> libavformat/tests/movenc.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
Looks good, will push.
--
Anton Khirnov
More information about the ffmpeg-devel
mailing list