[FFmpeg-devel] [PATCH v16 15/16] avcodec/subtitles: Migrate subtitle encoders to frame-based API and provide a compatibility shim for the legacy api

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Andreas
> Rheinhardt
> Sent: Friday, November 26, 2021 4:09 PM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v16 15/16] avcodec/subtitles: Migrate
> subtitle encoders to frame-based API and provide a compatibility shim for the
> legacy api
> 
> You ported all subtitle encoders at once; this has the downside of
> making the diff bigger and reviewing harder,

Nah, the changes are always the same, that's simple and straightforward.

> but the advantage of
> simplifying the compatibility code, because one knows that one does not
> need to care about the case of an encoder implementing the old API. Yet
> weirdly you didn't take advantage of this. You also did not remove
> AVCodec.encode_sub.

Are you saying I do not need to keep the compatibility layer for "legacy"
subtitle encoders?

I thought it's mandatory to keep it, but I'd be glad to remove..

softworkz