[FFmpeg-devel] 回复: [PATCH v4 2/2] avfilter: add a flip_vulkan filter

[Wu Jianhua]

Lynne:
>>ffmpeg at gyani.pro：
>>> On 2021-11-26 04:33 pm, Lynne wrote:
>>>
>>>> 26 Nov 2021, 11:37 by ffmpeg at gyani.pro:
>>>>
>>>>>
>>>>> On 2021-11-26 03:08 pm, Lynne wrote:
>>>>>
>>>>>> 26 Nov 2021, 10:10 by jianhua.wu at intel.com:
>>>>>>
>>>>>> This filter flips the input video both horizontally and vertically
>>>>>> in one compute pipeline, and it's no need to use two pipelines for
>>>>>> hflip_vulkan,vflip_vulkan anymore.
>>>>>>
>>>>>> Signed-off-by: Wu Jianhua <jianhua.wu at intel.com>
>>>>>> ---
>>>>>>  configure                    |  1 +
>>>>>>  libavfilter/allfilters.c     |  1 +
>>>>>>  libavfilter/vf_flip_vulkan.c | 61 +++++++++++++++++++++++++++++-------
>>>>>>  3 files changed, 51 insertions(+), 12 deletions(-)
>>>>>>
>>>>> I'll push this tonight if there are no further objections to the name.
>>>>>
>>>> Will other flip modes be added to this filter?
>>>>

Hi Gyan:

There are no more flip modes anymore. I add this filter is inspired by OpenCV,
which offers three flip modes for horizontal, vertical, and both. When a person
specifies hflip, it means that he is desired on horizontal flipping. If the flip
is specified without 'v' or 'h', it means there is no desire on specifying the
direction. So, I think it may be fine to use flip for both directions then we
don't need to construct a new name.

Thanks,
Jianhua

>>> No. Other flip modes are already separate filters, and transposition
>>> would be another filter. Our transpose filter doesn't support flipping
>>> the image, and to keep options compatible between software and
>>> hardware filters, we can't add it. So the most appropriate filter for
>>> this is a standalone one.
>>>
>>
>> If modes can be added, you can add them here, and deprecate the single mode variants.
>> Since these filters are very new, there are no legacy users to accommodate and now would be the best time they come become present in a release branch.
>>
>
>There are no more modes to be added, flipping != transpose != rotate,
>according to ffmpeg nomenclature, since we have separate filters for each.
>


________________________________________
发件人: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> 代表 Lynne <dev at lynne.ee>
发送时间: 2021年11月26日 3:45
收件人: FFmpeg development discussions and patches
主题: Re: [FFmpeg-devel] [PATCH v4 2/2] avfilter: add a flip_vulkan filter

26 Nov 2021, 12:20 by ffmpeg at gyani.pro:

>
>
> On 2021-11-26 04:33 pm, Lynne wrote:
>
>> 26 Nov 2021, 11:37 by ffmpeg at gyani.pro:
>>
>>>
>>> On 2021-11-26 03:08 pm, Lynne wrote:
>>>
>>>> 26 Nov 2021, 10:10 by jianhua.wu at intel.com:
>>>>
>>>>> This filter flips the input video both horizontally and vertically
>>>>> in one compute pipeline, and it's no need to use two pipelines for
>>>>> hflip_vulkan,vflip_vulkan anymore.
>>>>>
>>>>> Signed-off-by: Wu Jianhua <jianhua.wu at intel.com>
>>>>> ---
>>>>>  configure                    |  1 +
>>>>>  libavfilter/allfilters.c     |  1 +
>>>>>  libavfilter/vf_flip_vulkan.c | 61 +++++++++++++++++++++++++++++-------
>>>>>  3 files changed, 51 insertions(+), 12 deletions(-)
>>>>>
>>>> I'll push this tonight if there are no further objections to the name.
>>>>
>>> Will other flip modes be added to this filter?
>>>
>> No. Other flip modes are already separate filters, and transposition
>> would be another filter. Our transpose filter doesn't support flipping
>> the image, and to keep options compatible between software and
>> hardware filters, we can't add it. So the most appropriate filter for
>> this is a standalone one.
>>
>
> If modes can be added, you can add them here, and deprecate the single mode variants.
> Since these filters are very new, there are no legacy users to accommodate and now would be the best time they come become present in a release branch.
>

There are no more modes to be added, flipping != transpose != rotate,
according to ffmpeg nomenclature, since we have separate filters for each.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".