[FFmpeg-devel] [PATCH v3 1/1] fftools/ffprobe: print size of attachment streams (extradata_size)

Soft Works softworkz at hotmail.com
Sat Nov 27 00:01:23 EET 2021



> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Michael
> Niedermayer
> Sent: Friday, November 26, 2021 10:26 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v3 1/1] fftools/ffprobe: print size of
> attachment streams (extradata_size)
> 
> On Fri, Nov 26, 2021 at 07:55:40PM +0000, Soft Works wrote:
> >
> >
> > > -----Original Message-----
> > > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Michael
> > > Niedermayer
> > > Sent: Friday, November 26, 2021 7:50 PM
> > > To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> > > Subject: Re: [FFmpeg-devel] [PATCH v3 1/1] fftools/ffprobe: print size of
> > > attachment streams (extradata_size)
> > >
> > > On Thu, Nov 25, 2021 at 04:59:41PM +0000, Soft Works wrote:
> > > > Another attempt: Created on Linux and zipped...
> > >
> > > tested and works
> > > LGTM
> >
> > Thanks.
> >
> > Today I've seen that the v3 version with the patch as an attachment has
> > been processed by patchwork:
> >
> >
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/CH0P223MB03639F30A548FA85C1
> 7E8855BA629 at CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM/
> >
> > I've also verified that the output from git format-patch on Linux was the
> > same as on Windows. Also, I sent e-mails with the attached patch to myself
> > (google-to-google and google-to-ms) and verified that the attachments were
> > unchanged.
> >
> > My preliminary conclusion for patches containing long lines:
> >
> > For patchwork: Use the --attach param for git send-patch
> > For Michael and maybe others: send as zip attachment 😊
> > (not that I could tell the reason)
> >
> > Might be interesting to check whether there's a difference between the
> > e-mail you get and the file you get when downloading the mbox from
> patchwork.
> 
> The attachemnt after the mailing list is broken:
> https://ffmpeg.org/pipermail/ffmpeg-
> devel/attachments/20211125/daa80b4e/attachment.bin
> 
> if you want to help fix this, thats welcome
> 
> That patchwork has a working patch is interresting but iam not sure if the
> awnser to this will help, the problem seems before. So we need a fix before
> if you are interrested in helping, there was some prior occurance of this
> maybe there was some additional information in that thread

There are two problems - I'm not sure which one you are talking about:

1. Long lines are wrapped when patches are sent inline

The maximum line length for e-mails is 998 chars.
(RFC5322 Section 2.1.1, https://tools.ietf.org/html/rfc5322#section-2.1.1)

Probably not a bug, neither from patchwork nor from the mailing list software.
Conclusion is IMO that patches with long lines need to be sent as attachments
instead.


2. You didn't correctly receive the patch sent as attachment

I just double-checked: The ML software didn't modify the patch when attached
(as plain-text .patch)

Patchwork could apply this correctly, so I'm not sure what went wrong 
in that case when you couldn't apply it?

Kind regards,
softworkz








More information about the ffmpeg-devel mailing list